New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`ActiveModel.full_message` interaction with `index_errors` #33615

Merged
merged 2 commits into from Sep 7, 2018

Conversation

Projects
None yet
5 participants
@Larochelle
Contributor

Larochelle commented Aug 14, 2018

Summary

ActiveModel.full_message does not allow a custom i18n content when index_errors: true is used, as [0], [1], ..., [n] needs to be included in the i18n key

This affects the model and attribute format override as it's looking for a key with the Index as activemodel.errors.models.person/contacts[0]/addresses[0].attributes.street.format which would require n entries in the translations.

The attribute humanization is also affected as it sends the indexed key to human_attribute_name looking for the attribute at:
activemodel.attributes.person/contacts[0]/addresses[0].street
Which makes it impacticle to translate these attributes

Before this PR, the full message is generated as:
Contacts[0]/addresses[0] country cannot be blank

This PR allows to get:
Country cannot be blank

Other Information

The behaviour is fully behind the i18n_full_message setting so by default apps are not affected. An alternative could be to move the .remove(/\[\d\]/) so all apps get the behaviour change of human_attribute_name. I'm putting under the config in case some apps rely on the [0] being in the error message

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Aug 14, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

rails-bot commented Aug 14, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca rafaelfranca merged commit dd29fab into rails:master Sep 7, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment