New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guide to mention code linters available #33621

Merged
merged 1 commit into from Aug 19, 2018

Conversation

Projects
None yet
3 participants
@sikachu
Member

sikachu commented Aug 15, 2018

Contributors can run RuboCop locally to catch code style error in Ruby code and npm lint task for rails-ujs CoffeeScript and JavaScript code.

[skip ci]

Show outdated Hide outdated guides/source/contributing_to_ruby_on_rails.md
@sikachu

This comment has been minimized.

Show comment
Hide comment
@sikachu

sikachu Aug 15, 2018

Member

@kamipo fixed!

Member

sikachu commented Aug 15, 2018

@kamipo fixed!

@sikachu

This comment has been minimized.

Show comment
Hide comment
@sikachu

sikachu Aug 15, 2018

Member

Hold on — I think I need to make some update. 🙇

Member

sikachu commented Aug 15, 2018

Hold on — I think I need to make some update. 🙇

Update guide to mention code linters available
Contributors can run RuboCop locally to catch code style error in Ruby
code and npm lint task for `rails-ujs` CoffeeScript and JavaScript code.

[skip ci]

@schneems schneems merged commit 2247077 into rails:master Aug 19, 2018

1 check passed

codeclimate All good!
Details
@schneems

This comment has been minimized.

Show comment
Hide comment
@schneems

schneems Aug 19, 2018

Member

Thanks!

Member

schneems commented Aug 19, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment