Allow perform_enqueued_jobs to be called without a block.
#33626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performs all of the jobs that have been enqueued up to this point in the test.
|
r? @kamipo (@rails-bot has picked a reviewer for you, use r? to override) |
bogdanvlviv
approved these changes
Aug 15, 2018
guilleiguaran
approved these changes
Aug 16, 2018
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Aug 16, 2018
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Aug 20, 2018
Example: ``` def test_assert_performed_with MyJob.perform_later(1,2,3) perform_enqueued_jobs assert_performed_with(job: MyJob, args: [1,2,3], queue: 'high') end ``` Follow up rails#33626.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Performs all of the jobs that have been enqueued up to this point in the test.
Allows you to test code that is in some intermediate state between the time that the job is enqueued to the time that the job is performed. For example in my case, when uploading an image asynchronously a default image is set until the thumbnails have been processed in the background. This allows me to test that after the job is enqueued the default image is set, then call
perform_enqueued_jobsto make sure it then gets updated afterward.