Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action cable testing #33659

Merged
merged 2 commits into from Aug 22, 2018

Conversation

Projects
None yet
9 participants
@palkan
Copy link
Contributor

palkan commented Aug 19, 2018

This PR is a remake of the older PRs (#23211 and #27191).

After discussing it again we decided to get it done for Rails 6.

This PR is the first one in the series (and the base). The idea is to merge action-cable-testing gem into Rails, step by step:

  • Add Test adapter
  • Add Test helper (for broadcasting tests)
  • Add channels unit-testing support
  • Add connections unit-testing support
  • Generators
  • Guides

/cc @dhh @matthewd @kaspth

palkan added some commits Aug 19, 2018

@rails-bot

This comment has been minimized.

Copy link

rails-bot commented Aug 19, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@dhh

This comment has been minimized.

Copy link
Member

dhh commented Aug 21, 2018

I like this! There are some improvements to the implementation we can make, but I'd be happy to merge this first, and then make those improvements. Thanks again 👌

@eileencodes eileencodes added this to the 6.0.0 milestone Aug 22, 2018

@eileencodes eileencodes merged commit 9eee4c1 into rails:master Aug 22, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eileencodes

This comment has been minimized.

Copy link
Member

eileencodes commented Aug 22, 2018

Merged so we can make more progress and since DHH said he is happy to merge first.

@kaspth

This comment has been minimized.

Copy link
Member

kaspth commented Aug 22, 2018

@palkan thanks for all your help with this! I'm sorry it took so long ❤️

@bogdanvlviv bogdanvlviv referenced this pull request Aug 23, 2018

Merged

Follow up #33659 #33703

georgeclaghorn added a commit that referenced this pull request Aug 23, 2018

@victorhazbun

This comment has been minimized.

Copy link

victorhazbun commented Aug 26, 2018

Thank you @palkan

@ahcarpenter

This comment has been minimized.

Copy link

ahcarpenter commented Aug 26, 2018

Thanks for this @palkan!!

@rmacklin

This comment has been minimized.

Copy link
Contributor

rmacklin commented Aug 31, 2018

@palkan
After discovering anycable last year, I had found #23211 and had checked in on that PR from time to time. I'm super glad to see your contributions finally make it into rails after all this time! Thanks very much for persevering!

@palkan palkan changed the title [WIP] Action cable testing Action cable testing Nov 15, 2018

@seanfcarroll

This comment has been minimized.

Copy link

seanfcarroll commented Mar 19, 2019

Until we all update to v6, there is this gem available.

@palkan palkan deleted the palkan:feature/action-cable-testing branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.