Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `rails routes -c` for controller name consists of multiple word. #33662

Merged
merged 1 commit into from Aug 20, 2018

Conversation

@yskkin
Copy link
Contributor

yskkin commented Aug 20, 2018

Summary

rails routes -c UserPermissionsController did not output routes for corresponding controller because its name consists of multiple word.

@rails-bot
Copy link

rails-bot commented Aug 20, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @georgeclaghorn (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

actionpack/lib/action_dispatch/routing/inspector.rb Outdated
@@ -83,7 +83,7 @@ def format(formatter, filter = {})
private
def normalize_filter(filter)
if filter[:controller]
{ controller: /#{filter[:controller].downcase.sub(/_?controller\z/, '').sub('::', '/')}/ }
{ controller: /#{filter[:controller].underscore.sub(/_?controller\z/, '').sub('::', '/')}/ }

This comment has been minimized.

@kamipo

kamipo Aug 20, 2018 Member

We probably could remove .sub('::', '/') in favor of using .underscore.

@yskkin yskkin force-pushed the yskkin:multi_word_route branch to e2d0b3b Aug 20, 2018
@yskkin
Copy link
Contributor Author

yskkin commented Aug 20, 2018

addressed @kamipo's point and squashed

@kamipo kamipo merged commit ffca883 into rails:master Aug 20, 2018
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kamipo
Copy link
Member

kamipo commented Aug 20, 2018

Thanks!

@yskkin yskkin deleted the yskkin:multi_word_route branch Aug 20, 2018
@bogdanvlviv
Copy link
Contributor

bogdanvlviv commented Aug 21, 2018

Looks like a bug fix. Should we backport to 5-2-stable?

kamipo added a commit that referenced this pull request Aug 21, 2018
Fix `rails routes -c` for controller name consists of multiple word.
@kamipo
Copy link
Member

kamipo commented Aug 21, 2018

👍
Backported in ef64779.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.