New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database configuration to disable advisory locks. #33691

Merged
merged 1 commit into from Aug 22, 2018

Conversation

Projects
None yet
7 participants
@tgxworld
Contributor

tgxworld commented Aug 22, 2018

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Aug 22, 2018

r? @kamipo

(@rails-bot has picked a reviewer for you, use r? to override)

rails-bot commented Aug 22, 2018

r? @kamipo

(@rails-bot has picked a reviewer for you, use r? to override)

@tgxworld

This comment has been minimized.

Show comment
Hide comment
@tgxworld
Contributor

tgxworld commented Aug 22, 2018

@rails-bot rails-bot assigned matthewd and unassigned kamipo Aug 22, 2018

Show outdated Hide outdated guides/source/configuring.md Outdated
Show outdated Hide outdated activerecord/lib/active_record/connection_adapters/abstract_adapter.rb Outdated
Show outdated Hide outdated ...verecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb Outdated
Show outdated Hide outdated activerecord/CHANGELOG.md Outdated
@tgxworld

This comment has been minimized.

Show comment
Hide comment
@tgxworld

tgxworld Aug 22, 2018

Contributor

@matthewd Thank you for reviewing, I've updated the PR as per your comments.

Contributor

tgxworld commented Aug 22, 2018

@matthewd Thank you for reviewing, I've updated the PR as per your comments.

@matthewd matthewd merged commit 24f6bf0 into rails:master Aug 22, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matthewd

This comment has been minimized.

Show comment
Hide comment
@matthewd

matthewd Aug 22, 2018

Member

🤘🏻❤️

Member

matthewd commented Aug 22, 2018

🤘🏻❤️

:logger,
:prepared_statements,
:lock,
:advisory_locks

This comment has been minimized.

@georgeclaghorn

georgeclaghorn Aug 22, 2018

Member

Should this be :advisory_locks_enabled?

@georgeclaghorn

georgeclaghorn Aug 22, 2018

Member

Should this be :advisory_locks_enabled?

This comment has been minimized.

@rafaelfranca

rafaelfranca Aug 22, 2018

Member

I think it is matching prepared_statements. I'm fine with either one.

@rafaelfranca

rafaelfranca Aug 22, 2018

Member

I think it is matching prepared_statements. I'm fine with either one.

This comment has been minimized.

@georgeclaghorn

georgeclaghorn Aug 22, 2018

Member

The instance variable is named @advisory_locks_enabled.

@georgeclaghorn

georgeclaghorn Aug 22, 2018

Member

The instance variable is named @advisory_locks_enabled.

This comment has been minimized.

@tgxworld

tgxworld Aug 22, 2018

Contributor

@georgeclaghorn Oops good catch. Thank you for fixing @kamipo 👍

@tgxworld

tgxworld Aug 22, 2018

Contributor

@georgeclaghorn Oops good catch. Thank you for fixing @kamipo 👍

@tgxworld tgxworld deleted the tgxworld:add_config_to_disable_advisory_locks branch Aug 22, 2018

@faucct

This comment has been minimized.

Show comment
Hide comment
@faucct

faucct Aug 30, 2018

Contributor

Could this get a version bump (5.2.2 or 5.2.1.1)? Rails repository is very huge to fetch.

Contributor

faucct commented Aug 30, 2018

Could this get a version bump (5.2.2 or 5.2.1.1)? Rails repository is very huge to fetch.

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Aug 31, 2018

Member

This is only going to be present in Rails 6.0. And no, we only release when we think it is ready, we can't release after every merged PR.

Member

rafaelfranca commented Aug 31, 2018

This is only going to be present in Rails 6.0. And no, we only release when we think it is ready, we can't release after every merged PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment