Skip to content

ActionCable: add id option to redis adapter config - #33798

Merged
rafaelfranca merged 1 commit into
rails:masterfrom
got2be:actioncable-redis-client-name
Sep 6, 2018
Merged

ActionCable: add id option to redis adapter config#33798
rafaelfranca merged 1 commit into
rails:masterfrom
got2be:actioncable-redis-client-name

Conversation

@got2be

@got2be got2be commented Sep 5, 2018

Copy link
Copy Markdown
Contributor

Summary

Add id option to Redis adapter so now you can distinguish ActionCable's Redis connections among others. Also, you can set custom id in options.
Can be useful for debugging when a single Redis instance is used by multiple gems or applications.

Before:

$ redis-cli client list
id=669 addr=127.0.0.1:46442 fd=8 name= age=18 ...

After:

$ redis-cli client list
id=673 addr=127.0.0.1:46516 fd=8 name=ActionCable-PID-19413 age=2 ...

@rails-bot

Copy link
Copy Markdown

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants