New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate most methods which were never used in `DatabaseLimits` #33799

Merged
merged 1 commit into from Sep 5, 2018

Conversation

Projects
None yet
2 participants
@kamipo
Member

kamipo commented Sep 5, 2018

DatabaseLimits and those methods were introduced at 3809c80, but most
methods were never used and never tested from the beginning (except
table_alias_length, index_name_length, and in_clause_length (since
66c0937)).

There is no reason to maintain unused those methods for about 8 years.

Deprecate most methods which were never used in `DatabaseLimits`
`DatabaseLimits` and those methods were introduced at 3809c80, but most
methods were never used and never tested from the beginning (except
`table_alias_length`, `index_name_length`, and `in_clause_length` (since
66c0937)).

There is no reason to maintain unused those methods for about 8 years.

@kamipo kamipo merged commit 54a9dbf into rails:master Sep 5, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kamipo kamipo deleted the kamipo:deprecate_unused_methods_in_database_limits branch Sep 5, 2018

yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request Oct 5, 2018

Deprecated `table_name_length` and `column_name_length`
$ ARCONN=oracle bundle exec ruby -w -Itest test/cases/adapter_test.rb -n /length_is_deprecated/

rails/rails#33799

yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request Oct 8, 2018

Deprecated `table_name_length` and `column_name_length`
This pull request addresses these two failures to support rails/rails#33799
```
$ ARCONN=oracle bundle exec ruby -w -Itest test/cases/adapter_test.rb -n /length_is_deprecated/
... snip ...
Using oracle
Run options: -n /length_is_deprecated/ --seed 13009

.F

Failure:
ActiveRecord::AdapterTest#test_column_name_length_is_deprecated [test/cases/adapter_test.rb:306]:
Expected a deprecation warning within the block but received none

rails test test/cases/adapter_test.rb:305

F

Failure:
ActiveRecord::AdapterTest#test_table_name_length_is_deprecated [test/cases/adapter_test.rb:310]:
Expected a deprecation warning within the block but received none

rails test test/cases/adapter_test.rb:309

Finished in 0.020496s, 146.3696 runs/s, 146.3696 assertions/s.
3 runs, 3 assertions, 2 failures, 0 errors, 0 skips
$
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment