Remove useless argument #338

Closed
wants to merge 1 commit into
from

Projects

None yet

8 participants

@smartinez87
Contributor

The +name+ argument on the #columns method is useless, no implementation of this method makes use of it.
I removed the argument since it only creates confusion.

@henrikhodne
Contributor

SQLite 3 tests pass.

@tenderlove
Member

I'd like to avoid changing method signatures until Rails 4.0. This change will break backwards compatibility with 3rd party adapters.

@josevalim
Member

@tenderlove should we leave this open then? or can we close?

@henrikhodne
Contributor

Set up a milestone and add it?

@tenderlove
Member

Yes, we should set up a rails 4 milestone and add this.

@dchelimsky
Contributor

How about changing its name to something like deprecated for rails 3-1 so people know it's going to go away? That would also minimize the confusion that @smartinez87 cites.

@jeremy
Member
jeremy commented Oct 9, 2011

Milestoned @ Rails 4.0

@smartinez87
Contributor

master is rails 4 now right? should this be merged?

@rafaelfranca
Member

Yeah! Master is Rails 4.0 ❤️

@carlosantoniodasilva

@smartinez87 I think it'd be good to rebase so it can be merged now :)

@smartinez87
Contributor

had trouble rebasing master again, so opened a new PR #4850

@smartinez87
Contributor

closing this, since #4850 was merged

@smartinez87 smartinez87 closed this Feb 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment