The +name+ argument on the #columns method is useless, no implementation of this method makes use of it.
I removed the argument since it only creates confusion.
Remove useless argument on #columns
SQLite 3 tests pass.
I'd like to avoid changing method signatures until Rails 4.0. This change will break backwards compatibility with 3rd party adapters.
@tenderlove should we leave this open then? or can we close?
Set up a milestone and add it?
Yes, we should set up a rails 4 milestone and add this.
How about changing its name to something like deprecated for rails 3-1 so people know it's going to go away? That would also minimize the confusion that @smartinez87 cites.
Milestoned @ Rails 4.0
master is rails 4 now right? should this be merged?
Yeah! Master is Rails 4.0 ❤️
@smartinez87 I think it'd be good to rebase so it can be merged now :)
had trouble rebasing master again, so opened a new PR #4850
closing this, since #4850 was merged