New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include test helpers in ActionDispatch::IntegrationTest #33849

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
5 participants
@ricardotk002
Contributor

ricardotk002 commented Sep 12, 2018

Summary

Fixes #33838

As @dhh brings up, the point of ActionDispatch::IntegrationTest is to
allow users to test the integration of all the pieces called by a
controller. Asserting about the emails and jobs queued is part of that
task.

In this commit, I use the action_dispatch_integration_test hook to include
the ActionMailer::TestHelper and ActiveJob::TestHelper modules
when the ActionMailer and ActiveJob railties are initialized respectively.

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Sep 12, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @georgeclaghorn (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

rails-bot commented Sep 12, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @georgeclaghorn (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

Include test helpers when ActionDispatch::IntegrationTest is loaded
As @dhh brings up, the point of `ActionDispatch::IntegrationTest` is to
allow users to test the integration of all the pieces called by a
controller. Asserting about the emails and jobs queued is part of that
task.

This commit includes the `ActionMailer::TestHelper` and
`ActiveJob::TestHelper` modules when the ActionMailer and ActiveJob
railties are initialized respectively.

@rafaelfranca rafaelfranca merged commit b79f3cc into rails:master Sep 12, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
codeclimate All good!
Details
@dhh

This comment has been minimized.

Show comment
Hide comment
@dhh

dhh Sep 12, 2018

Member

❤️

Member

dhh commented Sep 12, 2018

❤️

bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Sep 13, 2018

Add changelog entries for rails#33849 [ci skip]
Since these changes related to the public API, I think we should add
changelog entries.

Related to rails#33838, rails#33849

kamipo added a commit that referenced this pull request Sep 13, 2018

Merge pull request #33869 from bogdanvlviv/add-changelog-entries-for-…
…33849

Add changelog entries for #33849 [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment