New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -X when loading structure.sql via psql #34001

Merged
merged 1 commit into from Sep 27, 2018

Conversation

Projects
None yet
4 participants
@dark-panda
Contributor

dark-panda commented Sep 27, 2018

Use the -X when loading structure.sql via psql. psql will load the ~/.psqlrc file which may contain settings that cause psql to block or otherwise cause undesired or unexpected behaviour.

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Sep 27, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

rails-bot commented Sep 27, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@kamipo

This comment has been minimized.

Show comment
Hide comment
@kamipo

kamipo Sep 27, 2018

Member

Can you address CI failure caused by changed arguments?
https://travis-ci.org/rails/rails/jobs/434032071

Member

kamipo commented Sep 27, 2018

Can you address CI failure caused by changed arguments?
https://travis-ci.org/rails/rails/jobs/434032071

@dark-panda

This comment has been minimized.

Show comment
Hide comment
@dark-panda

dark-panda Sep 27, 2018

Contributor

Ugh, sorry, tests fixed, patch rerolled and pushed. :/

Contributor

dark-panda commented Sep 27, 2018

Ugh, sorry, tests fixed, patch rerolled and pushed. :/

@kamipo kamipo merged commit 32da8c1 into rails:master Sep 27, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment