Skip to content

Fix HashWithIndifferentAccess#without bug#34012

Merged
rafaelfranca merged 1 commit intorails:masterfrom
abraham-chan:indifferent-access-without
Sep 28, 2018
Merged

Fix HashWithIndifferentAccess#without bug#34012
rafaelfranca merged 1 commit intorails:masterfrom
abraham-chan:indifferent-access-without

Conversation

@abraham-chan
Copy link
Contributor

Summary

Inconsistent behavior when calling without on a HashWithIndifferentAccess e.g.

{a: 1}.with_indifferent_access.without("a")
# {}
{a: 1}.with_indifferent_access.without(:a)
# {"a"=>1} 
# Expected {}

# But except works
{a: 1}.with_indifferent_access.except("a")
# {}
{a: 1}.with_indifferent_access.except(:a)
# {}

Other Information

I'm not sure if the approach I took was the correct one, but except behaves correctly and appears to do the exact same thing, as far as I can tell.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants