Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor migrations_path command option to database #34021

Conversation

@gmcgibbon
Copy link
Member

@gmcgibbon gmcgibbon commented Sep 28, 2018

Summary

As discussed in #33994, refactors migrations_paths command option in generators to database (aliased as db). Now, the migrations paths will be read from the specified database configuration in the current environment.

bin/rails g model Chair brand:string --database=kingston
     invoke  active_record
     create    db/kingston_migrate/20180830151055_create_chairs.rb

--database can be used with the migration, model, and scaffold generators.

r? @eileencodes

/cc @rafaelfranca @kaspth

Copy link
Member

@eileencodes eileencodes left a comment

Looks good, but there's a test failing

https://travis-ci.org/rails/rails/jobs/434724993#L1708

@eileencodes eileencodes added this to the 6.0.0 milestone Sep 28, 2018
@gmcgibbon gmcgibbon force-pushed the gmcgibbon:change_migrations_paths_command_option_to_db branch from 15a23b9 to 4775d3d Sep 28, 2018
@gmcgibbon
Copy link
Member Author

@gmcgibbon gmcgibbon commented Sep 28, 2018

Sorry about that, its 🍏 now!

@eileencodes eileencodes merged commit 7bc343b into rails:master Sep 28, 2018
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eileencodes
Copy link
Member

@eileencodes eileencodes commented Sep 28, 2018

Thanks!

@gmcgibbon gmcgibbon deleted the gmcgibbon:change_migrations_paths_command_option_to_db branch Oct 5, 2018
bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Oct 15, 2018
…ors [ci skip]

`migrations_paths` option was added to migration generator, with
changelog entry, in rails#33760.
Also `migrations_paths` option was added to model generator, with
changelog entry, in rails#33994.
Then `migrations_paths` was renamed to `database` and aliased as `db`
in rails#34021, and was added new changelog entry.
I think we should edit existed changelog entries instead adding new
about changing the name of the option from `migrations_paths` to `database`
since Rails 6.0 hasn't been released yet, and since It might confuse
readers of the changelog file in case if they've read changelog enty about
adding `migrations_paths` option but haven't read the entry about
change the name of that option to `database`.
@eileencodes, @gmcgibbon, @rafaelfranca Does it make sense?
y-yagi added a commit to y-yagi/rails that referenced this pull request Mar 20, 2019
Thor automatically adds `-` if aliases do not start with `-`.
https://github.com/erikhuda/thor/blob/0879c1773d188902d54f95174f33961ac33111f8/lib/thor/parser/options.rb#L53

But Thor follows a convention of one-dash-one-letter options.
So, even if `-` is added to `db`, it does not work.
https://github.com/erikhuda/thor/blob/0879c1773d188902d54f95174f33961ac33111f8/lib/thor/parser/options.rb#L4

Follow up rails#34021.
suketa added a commit to suketa/rails_sandbox that referenced this pull request Jun 9, 2019
* [Add migrations_paths option to migration generator](rails/rails#33760)
* [Add migrations_paths option to model generator](rails/rails#33994)
* [Refactor migrations_path command option to database](rails/rails#34021)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.