Refactor migrations_path command option to database#34021
Merged
eileencodes merged 1 commit intoSep 28, 2018
Merged
Conversation
eileencodes
reviewed
Sep 28, 2018
eileencodes
left a comment
eileencodes
left a comment
Member
There was a problem hiding this comment.
Looks good, but there's a test failing
gmcgibbon
force-pushed
the
change_migrations_paths_command_option_to_db
branch
from
15a23b9 to
4775d3d
Compare
Member
Author
|
Sorry about that, its 🍏 now! |
Member
|
Thanks! |
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Oct 15, 2018
…ors [ci skip] `migrations_paths` option was added to migration generator, with changelog entry, in rails#33760. Also `migrations_paths` option was added to model generator, with changelog entry, in rails#33994. Then `migrations_paths` was renamed to `database` and aliased as `db` in rails#34021, and was added new changelog entry. I think we should edit existed changelog entries instead adding new about changing the name of the option from `migrations_paths` to `database` since Rails 6.0 hasn't been released yet, and since It might confuse readers of the changelog file in case if they've read changelog enty about adding `migrations_paths` option but haven't read the entry about change the name of that option to `database`. @eileencodes, @gmcgibbon, @rafaelfranca Does it make sense?
y-yagi
added a commit
to y-yagi/rails
that referenced
this pull request
Mar 20, 2019
Thor automatically adds `-` if aliases do not start with `-`. https://github.com/erikhuda/thor/blob/0879c1773d188902d54f95174f33961ac33111f8/lib/thor/parser/options.rb#L53 But Thor follows a convention of one-dash-one-letter options. So, even if `-` is added to `db`, it does not work. https://github.com/erikhuda/thor/blob/0879c1773d188902d54f95174f33961ac33111f8/lib/thor/parser/options.rb#L4 Follow up rails#34021.
suketa
added a commit
to suketa/rails_sandbox
that referenced
this pull request
Jun 9, 2019
* [Add migrations_paths option to migration generator](rails/rails#33760) * [Add migrations_paths option to model generator](rails/rails#33994) * [Refactor migrations_path command option to database](rails/rails#34021)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #33994, refactors
migrations_pathscommand option in generators todatabase(aliased asdb). Now, the migrations paths will be read from the specified database configuration in the current environment.--databasecan be used with the migration, model, and scaffold generators.r? @eileencodes
/cc @rafaelfranca @kaspth