Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ActionDispatch::Http::ParameterFilter in favor of ActiveSup… #34039

Merged
merged 1 commit into from Oct 8, 2018

Conversation

@yskkin
Copy link
Contributor

@yskkin yskkin commented Oct 1, 2018

…port::ParameterFilter

Motivation

AR instance support filter_parameters since #33756.
Though Regex or Proc is valid as filter_parameters, they are not supported as AR#inspect.
#33756 (comment)

Moving ParameterFitler from ActionDispatch to ActiveSupport possibly make it easy to solve above issue by sharing ParameterFilter with AR and AD.

I'd like to get some feedback before working further on this.

@kamipo
Copy link
Member

@kamipo kamipo commented Oct 7, 2018

This is fine to me.
Do you have any extra work on this?

@yskkin yskkin force-pushed the parameter_filter branch from fa9a1d2 to 7f80be2 Oct 7, 2018
@yskkin
Copy link
Contributor Author

@yskkin yskkin commented Oct 7, 2018

@kamipo I just added activesupport's CHANGELOG.
I'll submit AR#inspect part in separate PR.

@yskkin
Copy link
Contributor Author

@yskkin yskkin commented Oct 7, 2018

CI failure looks unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants