Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db schema cache dump and clear multi db #34181

Merged

Conversation

@gmcgibbon
Copy link
Member

@gmcgibbon gmcgibbon commented Oct 10, 2018

Summary

Adds multi-db support to rails db:schema:cache:dump and rails db:schema:cache:clear. I assume we may need to do some followup on this for rails to actually use the other schema cache files, right?

r? @eileencodes
cc @rafaelfranca

@gmcgibbon gmcgibbon force-pushed the db_schema_cache_dump_and_clear_multi_db branch 3 times, most recently from 33c3fa1 to 4c2c2cf Oct 16, 2018
@gmcgibbon
Copy link
Member Author

@gmcgibbon gmcgibbon commented Oct 24, 2018

I believe we need to change this railtie initializer in ActiveRecord for other schema caches to be picked up on. That might be tricky if caches live in the connection object.

Loading

Copy link
Member

@eileencodes eileencodes left a comment

Minor update to the changelog needed. Otherwise looks good 👍

Loading

* Adds support for multiple databases to `rails db:schema:cache:dump`.

*Gannon McGibbon*

Copy link
Member

@eileencodes eileencodes Nov 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can write one changelog entry like "Adds support for multiple databases to rails db:schema:cache:dump and rails db:schema:cache:clear.

Also this should be in the AR changelog, not ralties

Loading

Copy link
Member Author

@gmcgibbon gmcgibbon Nov 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks 👍

Loading

Adds support for multiple databases to `rails db:schema:cache:dump`
and `rails db:schema:cache:clear`.
@gmcgibbon gmcgibbon force-pushed the db_schema_cache_dump_and_clear_multi_db branch from 4c2c2cf to ac18bda Nov 7, 2018
@eileencodes eileencodes merged commit fc2684c into rails:master Nov 7, 2018
2 checks passed
Loading
@gmcgibbon gmcgibbon deleted the db_schema_cache_dump_and_clear_multi_db branch Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants