Skip to content

Deprecate Unicode#normalize and Chars#normalize. - #34202

Merged
jeremy merged 3 commits into
rails:masterfrom
frodsan:deprecate-unicode-normalize
Oct 12, 2018
Merged

jeremy merged 3 commits into
rails:masterfrom
frodsan:deprecate-unicode-normalize

Conversation

@frodsan

@frodsan frodsan commented Oct 12, 2018

Copy link
Copy Markdown
Contributor

The default normalization used by Unicode and String are different. Unicode#normalize uses :nkfc while String#unicode_normalize defaults to :nfc(ref).

This is why I added the form to the deprecation message so if the method is called without parameters it recommends the correct normalization form for String#unicode_normalize:

>> ActiveSupport::Multibyte::Unicode.default_normalization_form
# => :kc
>> "".mb_chars.normalize
DEPRECATION WARNING: ActiveSupport::Multibyte::Chars#normalize is deprecated 
and will be removed from Rails 6.1. Use #unicode_normalize(:nfkc) instead.

r? @jeremy

@rails-bot

Copy link
Copy Markdown

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @jeremy (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@jeremy jeremy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thank you @frodsan!

MSG

raise ArgumentError, "#{form} is not a valid normalization variant", caller
end

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handling the default case separately is a nice touch that users will appreciate.

@jeremy
jeremy merged commit ee95bed into rails:master Oct 12, 2018
@frodsan
frodsan deleted the deprecate-unicode-normalize branch October 12, 2018 16:56
@frodsan

frodsan commented Oct 12, 2018

Copy link
Copy Markdown
Contributor Author

Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants