Deprecate Unicode#normalize and Chars#normalize. - #34202
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @jeremy (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
| MSG | ||
|
|
||
| raise ArgumentError, "#{form} is not a valid normalization variant", caller | ||
| end |
There was a problem hiding this comment.
Handling the default case separately is a nice touch that users will appreciate.
|
Thanks! 😄 |
The default normalization used by
UnicodeandStringare different.Unicode#normalizeuses:nkfcwhileString#unicode_normalizedefaults to:nfc(ref).This is why I added the form to the deprecation message so if the method is called without parameters it recommends the correct normalization form for
String#unicode_normalize:r? @jeremy