Deprecate ActiveSupport::Multibyte::Chars.consumes?

[frodsan]

In favor of String#is_utf8? method.

I think this method was made for internal use only, and its usage was removed here: https://github.com/rails/rails/pull/8261/files#diff-ce956ebe93786930e40f18db1da5fd46L39.

r? @jeremy

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @jeremy (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

[jeremy]

Some current usage, for context: https://github.com/search?l=Ruby&q=%22Chars.consumes%3F%22&type=Code

[jeremy]

Chars#consumes? → Chars.consumes?

[jeremy]

Let's indicate that usage changes from a String argument to a String method. Example:

ActiveSupport::Multibyte::Chars.consumes?(string) is deprecated and will be removed from Rails 6.1. Use string.is_utf8? instead.

[frodsan]

Thanks for the review! Most of the search results are projects that vendor activesupport so this may not affect that many users 😄