New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guide for the counter variable when rendering with the `as:` option #34233

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
4 participants
@lucasprag
Copy link
Contributor

lucasprag commented Oct 17, 2018

Summary

This PR adds a note to the guide to make sure people understand that when rendering a collection using partials like <%= render partial: "product", collection: @products, as: :item %>, the counter variable name will not be product_counter, but item_counter because of the as: option.

It should close #34199

This is my first PR to rails, I'm just trying to contribute, thanks.

@rails-bot

This comment has been minimized.

Copy link

rails-bot commented Oct 17, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rails-bot rails-bot bot added the docs label Oct 17, 2018

@y-yagi y-yagi merged commit 0f74fd1 into rails:master Oct 17, 2018

1 check passed

codeclimate All good!
Details
@y-yagi

This comment has been minimized.

Copy link
Member

y-yagi commented Oct 17, 2018

@lucasprag Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment