Update guide for the counter variable when rendering with the as: option#34233
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
@lucasprag Thanks for your contribution! |
Summary
This PR adds a note to the guide to make sure people understand that when rendering a collection using partials like
<%= render partial: "product", collection: @products, as: :item %>, the counter variable name will not beproduct_counter, butitem_counterbecause of theas:option.It should close #34199
This is my first PR to rails, I'm just trying to contribute, thanks.