Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progressive JPG MIME-type to default variable content types #34455

Conversation

@minimalweb
Copy link
Contributor

@minimalweb minimalweb commented Nov 15, 2018

Summary

I want to suggest including the MIME-type for progressive JPGs (image/pjpeg) in the list of variable content types. It is not an uncommon MIME-type and including it in the default list might save a bunch of people some debugging time, when something like this does not work out of the box:

<% if asset.attachment.image? %>
  <%= image_tag(asset.attachment.variant(resize: '100x100') %>
<% end %>

I know, you can configure this on a per-app basis, but I think it would also be reasonable to have this in the default list.

@rails-bot
Copy link

@rails-bot rails-bot commented Nov 15, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@vipulnsward vipulnsward removed the docs label Nov 16, 2018
Copy link
Member

@gmcgibbon gmcgibbon left a comment

I think if we already include variants of jpeg by default (image/jpg), and browsers support progressive jpegs, we should too. Can you please add a changelog entry?

@rails-bot rails-bot added the docs label Nov 21, 2018
@minimalweb
Copy link
Contributor Author

@minimalweb minimalweb commented Nov 21, 2018

Done.

Copy link
Member

@gmcgibbon gmcgibbon left a comment

👍 Thanks! Please squash your commits and we can look at getting this merged.

@minimalweb minimalweb force-pushed the progressive_jpeg_inclusion_as_variable_content_type branch from 2f83558 to 455a122 Nov 21, 2018
@rafaelfranca rafaelfranca merged commit 437d209 into rails:master Nov 23, 2018
2 checks passed
@scivola
Copy link

@scivola scivola commented Jun 20, 2019

I think the non-standard MIME type image/pjpeg has nothing to do with whether the JPEG is progressive or not.

Could you see “Uploaded MIME Types” in the following official page?
MIME Type Detection in Windows Internet Explorer

The old Internet Explorer provides image/pjpeg for an uploading JPEG file, even if it is not progressive.

So, the following sentence in the CHANGELOG is not so suitable, I think.

Add progressive JPG to default list of variable content types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants