Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Active storage add proxying and direct downloads #34477
Added the option to globally change how active storage files are delivered. Users can now set app.config.active_storage.delivery_method to [*:redirect, :proxy, :direct]. There's also the option to override at the model level using
This is just a rough draft, still could be DRYed up a bit, needs tests, and documentation. Just want to get some feedback before I go to far.
If you are updating any of the CHANGELOG files or are asked to update the
Finally, if your pull request affects documentation or any non-code
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @georgeclaghorn (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.
Please see the contribution instructions for more information.
I've been using for some production apps and the results are great! For example, https://idealguides.com/1998-Suzuki-DR200SE has a 168 KB image that now downloads in 43 ms! This image used to take about 500ms with the old redirect method. Best part, if you're a Cloudflare user, simply setting
if you have rails 6 compatible application you can use it like this