New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct a spelling error #34481
Correct a spelling error #34481
Conversation
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer queueing
but it seems we have more results for queuing
(including file/class names), so I think this is the right approach. Can you please find replace the rest of the places in our docs where we use queueing
instead of queuing
?
Also, please use [ci skip]
for documentation PRs. Thanks! 😄
@gmcgibbon I made the change, but stuck to markdown files. There seems to be a few places that the Changing the comments doesn't seem like it would cause any problems, but the errors make me a bit nervous as some people might be referencing those in their own code. How do you feel about me making those changes in comments and in the error messages? Specifically:
|
@jacobherrington You can change the comments without CI runs, but not error strings. Regardless, please squash your commits and I can merge what you have. Or, if you want to change the comments, I'll accept that too. |
@gmcgibbon Changes made. I'll make a separate PR for the error strings and discuss the merits of that change there (if there are any). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last comment, otherwise looks good 👍
My spellchecker flagged this as an incorrect spelling, upon further research it appears to be a point of contention in English. Either way might work. After further examination queuing is much more common in the Rails codebase so making this change will serve to standardize the spelling.
You missed one ref in |
Summary
My spellchecker flagged this as an incorrect spelling, upon further
research it appears to be a point of contention in English. Either way
might work.