New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query cache for multiple connections #34491

Merged
merged 1 commit into from Nov 21, 2018

Conversation

Projects
None yet
3 participants
@eileencodes
Member

eileencodes commented Nov 20, 2018

Currently the query cache is only aware of one handler so once we added
multiple databases switching on the handler we broke query cache for
those reading connections.

While #34054 is the proper fix, that fix is not straight forward and I
want to make sure that the query cache isn't just broken for all other
connections not in the main handler.

cc/ @rafaelfranca @matthewd @tenderlove

@eileencodes eileencodes added this to the 6.0.0 milestone Nov 20, 2018

@eileencodes eileencodes changed the title from Update query cache for all handlers to Fix query cache for multiple connections Nov 20, 2018

@eileencodes eileencodes force-pushed the fix-query-cache-on-multiple-connections branch from 63e41e2 to ddd5a41 Nov 20, 2018

@eileencodes eileencodes self-assigned this Nov 20, 2018

Fix query cache for multiple connections
Currently the query cache is only aware of one handler so once we added
multiple databases switching on the handler we broke query cache for
those reading connections.

While #34054 is the proper fix, that fix is not straight forward and I
want to make sure that the query cache isn't just broken for all other
connections not in the main handler.

@eileencodes eileencodes force-pushed the fix-query-cache-on-multiple-connections branch from ddd5a41 to aec635d Nov 20, 2018

@eileencodes eileencodes merged commit 536a190 into master Nov 21, 2018

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eileencodes eileencodes deleted the fix-query-cache-on-multiple-connections branch Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment