Stop using unnamed roots on conflict #34494
Merged
+22
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need a changelog entry |
Raises an ArgumentError when multiple root routes are defined in the same context instead of assigning nil names to subsequent roots.
gmcgibbon
force-pushed
the
warn_root_conflict
branch
from
82ae85b
to
dde9c48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #34479.
Disallows multiple uses of
rootwithin the same routing context withoutas:.The referenced issue maps the first
rootto/form/:foo, and a second one to/. When callingroot_pathin the template rendered by/, Rails knows to call the first root path (because it is the one with the name). The second root is not used, and can't be referenced by a named route helper because it doesn't have a name.This whole situation can be avoided by not assuming a root route should be unnamed if one already exists.
r? @rafaelfranca