Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand documentation for Hash#slice! #34497

Merged
merged 1 commit into from Nov 20, 2018
Merged

Expand documentation for Hash#slice! #34497

merged 1 commit into from Nov 20, 2018

Conversation

6temes
Copy link
Contributor

@6temes 6temes commented Nov 20, 2018

Summary

Expand the documentation for slice! method in order to make explicit what it really does.

Taking ActiveSuport::Multibyte as example.

# Works like <tt>String#slice!</tt>, but returns an instance of

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca rafaelfranca merged commit 9fb53e7 into rails:master Nov 20, 2018
@6temes 6temes deleted the make_documentation_for_slice_more_explicit branch November 20, 2018 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants