Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that delete_all on collection proxy returns affected count #34609

Merged
merged 1 commit into from Dec 4, 2018

Conversation

@kamipo
Copy link
Member

@kamipo kamipo commented Dec 4, 2018

Unlike the Relation#delete_all, delete_all on collection proxy
doesn't return affected count. Since the CollectionProxy is a subclass
of the Relation, this inconsistency is probably not intended, so it
should return the count consistently.

Unlike the `Relation#delete_all`, `delete_all` on collection proxy
doesn't return affected count. Since the `CollectionProxy` is a subclass
of the `Relation`, this inconsistency is probably not intended, so it
should return the count consistently.
@kamipo kamipo merged commit 4d7354a into rails:master Dec 4, 2018
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kamipo added a commit that referenced this pull request Dec 4, 2018
Ensure that `delete_all` on collection proxy returns affected count
@kamipo kamipo deleted the kamipo:delete_all_on_collection_proxy branch Dec 4, 2018
kamipo added a commit that referenced this pull request Dec 4, 2018
Ensure that `delete_all` on collection proxy returns affected count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant