Application controller test file #3461

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Member

arunagw commented Oct 29, 2011

Ok so I was running rake test:uncommitted on a new generated application and I got the error that no such file to load functional/application_controller_test.rb

One way to fix this is fix the task itself to not include ApplicationController in the list.

But I think we should generate the ApplicationControllerTest file

arunagw added some commits Oct 29, 2011

Generating Test file for ApplicationController
At the time of generating new application
generating test file for ApplicationController
Contributor

josevalim commented Oct 29, 2011

Instead, shouldn't the rake task be smarter and check if the test file exists before running it?

Member

arunagw commented Oct 29, 2011

@josevalim Yes that can be a fix. I was simply thinking that as we generate tests for scaffold resource. So a new application can give a empty test file for ApplicationController

Contributor

henrikhodne commented Nov 8, 2011

I think the rake task should be smarter as well. Close this and go for #3564 instead?

Contributor

josevalim commented Nov 8, 2011

Closing this and favor #3564

@josevalim josevalim closed this Nov 8, 2011

arunagw added a commit to arunagw/rails that referenced this pull request Nov 8, 2011

Should be checking if file exists or not.
I found this bug when running rake test:uncommitted 
on a newly generated rails app which don't have
test file for application_controller.
Can see detail here #3461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment