Preserve key order of #fetch_multi #34700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy
approved these changes
Dec 13, 2018
activesupport/CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| * Preserve key order of `ActiveSupport::CacheStore#fetch_multi`. | |||
There was a problem hiding this comment.
Let's illuminate this a bit, e.g. fetch_multi(*names) returns its results in the same order as the *names requested, rather than returning cache hits followed by cache misses.
gmcgibbon
force-pushed
the
fetch_multi_key_order
branch
from
a8915d3
to
4597418
Compare
kaspth
reviewed
Dec 18, 2018
|
|
||
| write_multi writes, options | ||
| end | ||
| names.map { |name| [name, reads.fetch(name) { writes[name] }] }.to_h |
There was a problem hiding this comment.
Tried grokking this over multiple attempts, but I find the two maps quite confusing since we seem to do similar yet different processing.
What if we kept some of the old flow ala this?
instrument :read_multi, names, options do |payload|
reads = read_multi_entries(names, options)
payload[:hits] = reads.keys
payload[:super_operation] = :fetch_multi
writes = {}
ordered = names.each_with_object({}) do |name, hash|
hash[name] = reads.fetch(name) { writes[name] = yield name }
end
write_multi writes, options
ordered
end(Probably ends up needing to be yield(name). Psst, also a nice case for index_with, but we can't use core extensions here.)
fetch_multi(*names) now returns its results in the same order as the `*names` requested, rather than returning cache hits followed by cache misses.
gmcgibbon
force-pushed
the
fetch_multi_key_order
branch
from
4597418
to
94ecf95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #34694.
Preserves order of keys passed to
#fetch_multi.If for some reason the current functionality is intended, I'll refactor this PR to document the behaviour.