Allow using parsed_body in ActionController::TestCase #34717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbuehlmann
changed the title
parsed_body in ActionController::TestCase… by switching the initialzation of an appropriate response parser in `ActionDispatch::TestResponse` from eagerly to lazily. By doing so, the response parser can be correctly set for `ActionController::TestCase`, which doesn't include the content type header in the constructor but only sets it at a later time. Fixes rails#34676.
tbuehlmann
force-pushed
the
controller-test-parsed-body
branch
from
048193b
to
8246a81
Compare
|
Thanks! |
suketa
added a commit
to suketa/rails_sandbox
that referenced
this pull request
Aug 12, 2019
Allow using parsed_body in ActionController::TestCase rails/rails#34717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow using
parsed_bodyinActionController::TestCaseby switching the initialzation of an appropriate response parserin
ActionDispatch::TestResponsefrom eagerly to lazily.By doing so, the response parser can be correctly set for
ActionController::TestCase, which doesn't includethe content type header in the constructor but only sets it at
a later time.
Fixes #34676.