Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add option to set parallel test worker count to the physical core count of the machine #34735
referenced this pull request
Dec 17, 2018
I guess tests failed because the physical core count of the Travis' server is equal to 1.
I like it spelling out as well…
On Dec 19, 2018, at 00:55, Bogdan ***@***.***> wrote: @bogdanvlviv commented on this pull request. In railties/lib/rails/generators/rails/app/templates/test/test_helper.rb.tt: > <%- else -%> - parallelize(workers: 2) + parallelize(workers: :number_of_processors) I thought that it would be better to keep this in this form since it would be easier for users to figure out that their tests use the actual core count as a number of workes. But I don't have strong opinions. I think that we should either simplify this to parallelize and parallelize(with: :threads)(a few lines above), or extend it to parallelize(workers: :number_of_processors, with: :processes) to emphasize that test suit run use "fork approach". — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.