Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Ruby 2.5 for Rails 6. #34754

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Projects
None yet
2 participants
@kaspth
Copy link
Member

commented Dec 19, 2018

Generally followed the pattern for #32034

  • Removes needless CI configs for 2.4
  • Targets 2.5 in rubocop
  • Updates existing CHANGELOG entries for fewer merge conflicts
  • Removes Hash#slice extension as that's inlined on Ruby 2.5.
  • Removes the need for send on define_method in MethodCallAssertions.

cc @jeremy @matthewd @dhh

Require Ruby 2.5 for Rails 6.
Generally followed the pattern for #32034

* Removes needless CI configs for 2.4
* Targets 2.5 in rubocop
* Updates existing CHANGELOG entries for fewer merge conflicts
* Removes Hash#slice extension as that's inlined on Ruby 2.5.
* Removes the need for send on define_method in MethodCallAssertions.
@kaspth

This comment has been minimized.

Copy link
Member Author

commented Dec 19, 2018

Well, that's helpful rails-bot 😂@gmcgibbon are you up for tuning the auto-labeling?

@jeremy

jeremy approved these changes Dec 19, 2018

Copy link
Member

left a comment

Relaying from @matthewd, who noted that Ruby 2.5 will be over a year old at Rails 6 release, aligning neatly with our "oldest fully-maintained version at release time" Ruby version plan.

@kaspth kaspth merged commit 04159a7 into master Dec 19, 2018

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kaspth kaspth deleted the require-ruby-2.5 branch Dec 19, 2018

biow0lf added a commit to evemonk/eve_online that referenced this pull request Dec 19, 2018

georgeclaghorn added a commit to rails/actionmailbox that referenced this pull request Dec 20, 2018

Remove Ruby 2.4 from the test matrix
Rails 6 will require Ruby 2.5 or newer. See rails/rails#34754.

@ahorek ahorek referenced this pull request Dec 20, 2018

Merged

fix tests for mail 2.8 #34756

yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request Dec 20, 2018

@yahonda yahonda referenced this pull request Dec 20, 2018

Merged

Rails 6 requires Ruby 2.5 #1801

kamipo added a commit to kamipo/rails that referenced this pull request Dec 20, 2018

bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Dec 20, 2018

Fix a few deprecation warnings
Since rails#34754 Rails 6.0 requires Ruby 2.5+

@bogdanvlviv bogdanvlviv referenced this pull request Dec 20, 2018

Merged

Follow up #34754 #34762

bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Dec 20, 2018

Follow up rails#34754
- Fix a few deprecation warnings
- Remove testing of `Hash#slice`
- Imporve test of `Hash#slice!`
- Remove mention about `Hash#slice` from the guide

kaspth added a commit that referenced this pull request Dec 20, 2018

bogdanvlviv added a commit to bogdanvlviv/actiontext that referenced this pull request Dec 20, 2018

Remove Ruby 2.4 from the CI matrix
Rails 6 requires Ruby 2.5+ or newer.
See rails/rails#34754.

@007lva 007lva referenced this pull request Dec 23, 2018

Closed

Support Ruby 2.5+ #921

4 of 4 tasks complete

pixeltrix added a commit to pixeltrix/rspec-rails that referenced this pull request Jan 24, 2019

Remove Ruby 2.4.4 from the Rails master matrix
Rails 6.0 will require Ruby >= 2.5.0 - see rails/rails#34754.

samphippen added a commit to rspec/rspec-rails that referenced this pull request Jan 24, 2019

Remove Ruby 2.4.4 from the Rails master matrix (#2073)
Rails 6.0 will require Ruby >= 2.5.0 - see rails/rails#34754.

benoittgt added a commit to benoittgt/rspec-rails that referenced this pull request Feb 22, 2019

benoittgt added a commit to rspec/rspec-rails that referenced this pull request Feb 23, 2019

samphippen added a commit to rspec/rspec-rails that referenced this pull request Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.