Stable migrations version order #3476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bcrypt 3 1 stable
backtrace, because JRuby reports the call to __send__ in the backtrace. In JRuby first is "org/jruby/RubyKernel.java"
…1-stable Jruby activesupport fix 3 1 stable for JRuby
Find in batch fix
Find in batches changelog
Fix AssetNotPrecompiledError behavior
Add entry about Asset behaviour fix to ActionPack ChangeLog
Need to make sure about order here.
Never return stored content from content_for when a block is given
Remove unused config variable from test.rb template
Backport rails#2789 to 3-1-stable
…ct_options!` `ActiveSupport::OrderedHash` is actually a subclass of the hash, so it does make sense that it should be extractable from the array list.
…ered_hash Make `ActiveSupport::OrderedHash` extractable when using `Array#extract_options!`
Fix bad options order in AR::Migration::CommandRecorder#invert_rename_index
Last orders the records by id
Uglifier bump
…s they have been failing intermittently for a long while due to what appears to be a Ruby bug. If anyone has the skills/expertise/time to debug this, please speak to the Travis guys.
…_broken_yaml_exception in fixtures_test.rb on Ruby 1.8.7.
…ng-the-sequel assets rake task refactoring work - the sequel
…hout assets_path.
ruby193: String#prepend for 3-1-stable
…oesn't throw Sprockets::FileOutsidePaths exception anymore
An association between two models cannot be made if a relevant key is unknown, so fail fast rather than generating invalid SQL. Fixes rails#3207.
This reverts commit 29a5aea.
Signed-off-by: José Valim <jose.valim@gmail.com>
…ure task. Leaving the path unquoted causes errors in paths containing spaces or dashes.
…erver configuration for gzipped assets pending)
…d assets, and expands the information about nginx support for this A robust Apache configuration for this feature seems to be tricky, one that takes into account Accept-Encoding, sets Vary, ensures Content-Type is right, etc.
|
Sorry about this bogus pull request. |
…ons table This reduces churn in the db/development_structure.sql file when using :sql as active_record.schema_format, and makes comparing diffs much easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dump_schema_information: now explicitly orders inserts into schema_migrations table by version valueWe use
active_record.schema_format = :sqlas our schema dump format, and thedb/development_structure.sqlsees quite a bit of trivial churn in the git history due to migrations having run in different orders, as migrations are created on different feature branches over time. With this trivial fix, only added/removed migrations will create changes to the schema dump file.The complete activerecord test suite with all database drivers pass with this change. Unfortunately, that doesn't say a big deal, as
dump_schema_informationis only called by thedb:structure:dumprake-task. Local manual testing does confirm the change, though.Suggestions for tests to add?