Import Action Mailbox #34786
Merged
Import Action Mailbox #34786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 17, 2018 16:30
Won't need Base and can separate routing from execution 👍
…redefined Too much hassle to manage all the steps compared to just pointing to an .eml fixture and having it setup for you.
There'll probably be other concerns we need to do around the processing.
Then InboundEmail doesn't need to serialize or track the exception that went with it. The arrow will point the other way.
Don't want to trigger app-specific behavior here.
Makes it easier to test without triggering this behavior.
Add Mailbox and MailboxTest generators
1.Don't generate ApplicationMailboxTest when executing installer 2. Hookup test_unit, so console doesn't throw errors
Fix Rails generators
Just a small mention that we can use generators inside README.
This matches Rails master, and it should make TravisCI green.
Set ruby >= 2.4.1 as min required version
Subtile mention of generator inside README
Generators only have the public `process` action, so there's nothing else to generate here. Skip the needless indirection.
Fits with rails/generators/channel containing: - channel_generator.rb - templates/ - USAGE
Running `./bin/rails generate mailbox application --no-test-framework` generates: ``` class ApplicationMailbox < ApplicationMailbox def process end end ``` which is not correct for the application mailbox. It shouldn't respond to process but it should contain a routing hint. Generally generators aren't meant to be used like the previous commit. The mailbox generator can certainly add in the ApplicationMailbox if missing, but it shouldn't be called with "application" as an argument. Also adds back auto inserting an `ingress` config line in `config/environmnets/production.rb`. Fixes #13. [Kasper Timm Hansen, Andrew Babichev]
…ssage_id Added logging when Message ID wasn't extracted
Rails 6 will require Ruby 2.5 or newer. See #34754.
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Dec 26, 2018
Merged
bogdanvlviv
reviewed
Dec 26, 2018
| @@ -8,6 +8,7 @@ AllCops: | |||
| - '**/vendor/**/*' | |||
| - 'actionpack/lib/action_dispatch/journey/parser.rb' | |||
| - 'railties/test/fixtures/tmp/**/*' | |||
| - 'actionmailbox/test/dummy/**/*' | |||
There was a problem hiding this comment.
Since we haven't excluded all cops for activestorage/test/dummy/**/**, probably we should consider turning on all the cops for actionmailbox/test/dummy/**/* to keep consistency? We can just run rubocop -a to fix all offenses under the dummy directory.
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Jan 13, 2019
Action Mailbox and Action Text belong to rails/rails since rails#34786 and rails#34873.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.