Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Action Mailbox #34786

merged 212 commits into from Dec 26, 2018

Import Action Mailbox #34786

merged 212 commits into from Dec 26, 2018


Copy link

@georgeclaghorn georgeclaghorn commented Dec 25, 2018

No description provided.

dhh added 30 commits Sep 17, 2018
Won't need Base and can separate routing from execution 👍

Too much hassle to manage all the steps compared to just pointing to an .eml fixture and having it setup for you.
There'll probably be other concerns we need to do around the processing.
Then InboundEmail doesn't need to serialize or track the exception that went with it. The arrow will point the other way.
Don't want to trigger app-specific behavior here.
Makes it easier to test without triggering this behavior.
georgeclaghorn and others added 13 commits Dec 16, 2018
Set ruby >= 2.4.1 as min required version
Subtile mention of generator inside README
Generators only have the public `process` action, so there's nothing
else to generate here.

Skip the needless indirection.
Fits with rails/generators/channel containing:

 - channel_generator.rb
 - templates/
Running `./bin/rails generate mailbox application --no-test-framework` generates:


class ApplicationMailbox < ApplicationMailbox
  def process

which is not correct for the application mailbox. It shouldn't
respond to process but it should contain a routing hint.

Generally generators aren't meant to be used like the previous commit.
The mailbox generator can certainly add in the ApplicationMailbox
if missing, but it shouldn't be called with "application" as an argument.

Also adds back auto inserting an `ingress` config line in

Fixes #13.

[Kasper Timm Hansen, Andrew Babichev]

Added logging when Message ID wasn't extracted
Rails 6 will require Ruby 2.5 or newer. See #34754.
@georgeclaghorn georgeclaghorn force-pushed the georgeclaghorn:actionmailbox branch 6 times, most recently from 077937d to 141886e Dec 25, 2018
@georgeclaghorn georgeclaghorn force-pushed the georgeclaghorn:actionmailbox branch from 141886e to a5b2fff Dec 26, 2018
@georgeclaghorn georgeclaghorn merged commit 9b35b9f into rails:master Dec 26, 2018
2 checks passed
2 checks passed
codeclimate All good!
continuous-integration/travis-ci/pr The Travis CI build passed
@georgeclaghorn georgeclaghorn deleted the georgeclaghorn:actionmailbox branch Dec 26, 2018
bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Dec 26, 2018
Follow up rails#34786
@bogdanvlviv bogdanvlviv mentioned this pull request Dec 26, 2018
@@ -8,6 +8,7 @@ AllCops:
- '**/vendor/**/*'
- 'actionpack/lib/action_dispatch/journey/parser.rb'
- 'railties/test/fixtures/tmp/**/*'
- 'actionmailbox/test/dummy/**/*'

This comment has been minimized.


bogdanvlviv Dec 26, 2018

Since we haven't excluded all cops for activestorage/test/dummy/**/**, probably we should consider turning on all the cops for actionmailbox/test/dummy/**/* to keep consistency? We can just run rubocop -a to fix all offenses under the dummy directory.

bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Jan 13, 2019
Action Mailbox and Action Text belong to rails/rails since rails#34786 and rails#34873.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
You can’t perform that action at this time.