Add Action Mailbox to guides - #34812
Merged
georgeclaghorn merged 3 commits intoDec 30, 2018
Merged
Conversation
bogdanvlviv
force-pushed
the
action_mailbox-guides-docs
branch
4 times, most recently
from
December 28, 2018 09:10
d05a831 to
f346119
Compare
This was referenced Dec 28, 2018
Contributor
There was a problem hiding this comment.
Suggested change
| * How to test test incoming emails. | |
| * How to test incoming emails. |
Contributor
There was a problem hiding this comment.
Suggested change
| * How to generate and setup a mailbox. | |
| * How to generate and route emails to a mailbox. |
Contributor
There was a problem hiding this comment.
I know this is fussy, but setup is a noun. Set up is the verb form.
Suggested change
| Install migrations needed for `InboundEmail` and ensure Active Storage is setup: | |
| Install migrations needed for `InboundEmail` and ensure Active Storage is set up: |
Contributor
There was a problem hiding this comment.
This came from the README, but can we go with “Configuration” here?
Suggested change
| ## Configuring | |
| ## Configuration |
Contributor
There was a problem hiding this comment.
Suggested change
| Then setup a mailbox: | |
| Then set up a mailbox: |
…guide [ci skip] I added WIP label to that guide since we definitely want to complement it.
Now Action Mailbox is responsible for receiving emails.
bogdanvlviv
force-pushed
the
action_mailbox-guides-docs
branch
from
December 30, 2018 00:43
f346119 to
67ecabe
Compare
Contributor
Author
|
Thank you for the review! 🙇♂️ I just fixed the mentioned typos. |
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Jan 5, 2019
- Move some actiontext/README.md content to Action Text Overview guide - I added WIP label to that guide since we definitely want to complement it. - Add Action Text to Major Features of Rails 6.0 Similar approach was used in rails#34812
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Jan 13, 2019
…skip] In rails#34709 we updated the guide, but `actioncable/README.md` is still outdated. Instead of fixing content in the file. I suggest not duplicate the info that is already in the guide and instead remove the info from the file and just add a message: "You can read more about Action Cable in the [Action Cable Overview](https://edgeguides.rubyonrails.org/action_cable_overview.html) guide." The same approach is being used for Action Mailbox and Action Text, see rails#34812 and rails#34878.
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Jan 21, 2019
We added "Action Mailbox Basics", "Action Text Overview" guides(rails#34812, rails#34878) I think it makes to mention about it in the changelog file. (Similar to 7200ec9) Note that entries retain original author since I just moved content from readme files to the guides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actionmailbox/README.mdcontent to Action Mailbox Basics guideI added WIP label to that guide since we definitely want to complement it.
Now Action Mailbox is responsible for receiving emails.
Related to #34786
Closes #34819
r? @georgeclaghorn