Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Action Text to guides [ci skip] #34878

Merged
merged 1 commit into from Jan 5, 2019

Conversation

bogdanvlviv
Copy link
Contributor

@bogdanvlviv bogdanvlviv commented Jan 5, 2019

  • Move some actiontext/README.md content to Action Text Overview guide
  • I added WIP label to that guide since we definitely want to complement it.
  • Add Action Text to Major Features of Rails 6.0

Similar approach was used in #34812
/cc @georgeclaghorn

- Move some actiontext/README.md content to Action Text Overview guide
- I added WIP label to that guide since we definitely want to complement it.
- Add Action Text to Major Features of Rails 6.0

Similar approach was used in rails#34812
@bogdanvlviv bogdanvlviv force-pushed the action_text-guides-docs branch from 22da0f9 to 0fb6c90 Compare Jan 5, 2019
@georgeclaghorn georgeclaghorn merged commit a4c0157 into rails:master Jan 5, 2019
1 check passed
@bogdanvlviv bogdanvlviv deleted the action_text-guides-docs branch Jan 5, 2019
bogdanvlviv added a commit to bogdanvlviv/rails that referenced this issue Jan 13, 2019
…skip]

In rails#34709 we updated the guide, but `actioncable/README.md` is still
outdated. Instead of fixing content in the file. I suggest
not duplicate the info that is already in the guide and instead remove
the info from the file and just add a message:
"You can read more about Action Cable in the
[Action Cable Overview](https://edgeguides.rubyonrails.org/action_cable_overview.html) guide."

The same approach is being used for Action Mailbox and Action Text,
see rails#34812 and rails#34878.
bogdanvlviv added a commit to bogdanvlviv/rails that referenced this issue Jan 21, 2019
We added "Action Mailbox Basics", "Action Text Overview" guides(rails#34812, rails#34878)
I think it makes to mention about it in the changelog file. (Similar to 7200ec9)
Note that entries retain original author since
I just moved content from readme files to the guides.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants