Allow strong params in ActiveRecord::Base#exists? #34891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
reviewed
Jan 7, 2019
Member
There was a problem hiding this comment.
Am I missing something or this test is not using Parameters?
Member
Author
There was a problem hiding this comment.
🤦♂️ My bad, fixed now.
Allow `ActionController::Params` as argument of `ActiveRecord::Base#exists?`
gmcgibbon
force-pushed
the
ac_params_exists
branch
from
299cec8 to
1e923b4
Compare
Contributor
|
I thought we had deprecated exists? without arguments? |
Member
Not that I'm aware. Why would we do that? |
Contributor
|
I can't for the life of me find that discussion now via GitHub's search. I just seem to remember @matthewd and either @eugeneius and @kamipo talking about this. |
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Jan 17, 2019
Clarify changelog entry Related to rails#34891
suketa
added a commit
to suketa/rails_sandbox
that referenced
this pull request
Jul 13, 2019
Allow strong params in ActiveRecord::Base#exists? rails/rails#34891
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #34752.
Allows
ActionController::Paramsas argument ofActiveRecord::Base#exists?. This works already for#createand#where, so I think this change makes sense.