New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all npm packages to @rails scope #34905

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
2 participants
@javan
Copy link
Member

javan commented Jan 9, 2019

Fixes #33083

actioncable   → @rails/actioncable
actiontext    → @rails/actiontext
activestorage → @rails/activestorage
rails-ujs     → @rails/ujs

TODO:

*npm doesn’t have a built-in system for moving or renaming packages

@javan javan force-pushed the javan:move-npm-packages-to-rails-scope branch from de9c04b to f7d56c1 Jan 9, 2019

@kaspth

kaspth approved these changes Jan 9, 2019

Copy link
Member

kaspth left a comment

Cool! What happens when people next go to call yarn install and the packages have been renamed?

Show resolved Hide resolved RELEASING_RAILS.md Outdated
@javan

This comment has been minimized.

Copy link
Member

javan commented Jan 9, 2019

What happens when people next go to call yarn install and the packages have been renamed?

The packages aren't being renamed, technically. They're being published as new packages with new names. So, existing applications will need to update their package.jsons to point to the new packages.

@javan javan force-pushed the javan:move-npm-packages-to-rails-scope branch 3 times, most recently from e096280 to e2d4d04 Jan 9, 2019

@javan javan force-pushed the javan:move-npm-packages-to-rails-scope branch from e2d4d04 to 86b489e Jan 10, 2019

@javan javan merged commit 2163762 into rails:master Jan 10, 2019

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@javan javan deleted the javan:move-npm-packages-to-rails-scope branch Jan 10, 2019

@jmalcic jmalcic referenced this pull request Jan 17, 2019

Merged

Improve alert handling #584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment