Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all npm packages to @rails scope #34905

Merged
merged 1 commit into from Jan 10, 2019

Conversation

@javan
Copy link
Member

@javan javan commented Jan 9, 2019

Fixes #33083

actioncable   → @rails/actioncable
actiontext    → @rails/actiontext
activestorage → @rails/activestorage
rails-ujs     → @rails/ujs

TODO:

*npm doesn’t have a built-in system for moving or renaming packages

@kaspth
kaspth approved these changes Jan 9, 2019
Copy link
Member

@kaspth kaspth left a comment

Cool! What happens when people next go to call yarn install and the packages have been renamed?

RELEASING_RAILS.md Outdated Show resolved Hide resolved
@javan
Copy link
Member Author

@javan javan commented Jan 9, 2019

What happens when people next go to call yarn install and the packages have been renamed?

The packages aren't being renamed, technically. They're being published as new packages with new names. So, existing applications will need to update their package.jsons to point to the new packages.

@javan javan force-pushed the javan:move-npm-packages-to-rails-scope branch 3 times, most recently from e096280 to e2d4d04 Jan 9, 2019
Fixes #33083
@javan javan force-pushed the javan:move-npm-packages-to-rails-scope branch from e2d4d04 to 86b489e Jan 10, 2019
@javan javan merged commit 2163762 into rails:master Jan 10, 2019
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@javan javan deleted the javan:move-npm-packages-to-rails-scope branch Jan 10, 2019
@connorshea
Copy link
Contributor

@connorshea connorshea commented Jan 22, 2019

@javan shouldn't this be mentioned in the CHANGELOG and/or Release Notes?

@javan
Copy link
Member Author

@javan javan commented Jan 28, 2019

@connorshea, yes thank you! Added here e3d4333.

@benreyn
Copy link

@benreyn benreyn commented Nov 15, 2019

I just ran into this issue on a project where I couldn't figure out why I wasn't getting this fix and there was no version 6.0.0 for rails-ujs. Does npm provide any mechanism for communicating this better? Other than digging through the changelog, issues, and source code, there was no (obvious) indication of this change. At the very least should a post-install script log a message that says something to the effect of rails-ujs has been deprecated. Please use @rails/ujs instead (This would involve a version bump to the old package)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants