Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rails test:channels and fix Action Cable templates #34947

Merged
merged 2 commits into from Jan 16, 2019

Conversation

@bogdanvlviv
Copy link
Contributor

@bogdanvlviv bogdanvlviv commented Jan 16, 2019

  • Remove frozen_string_literal from Action Cable's template files
    Related to 837f602.
    Follow up #34933
    Fix the testing guide.

  • Add rails test:channels.
    Add this rake task to test channels only.
    We've added rails test:mailboxes recently in the same way #34828.

@bogdanvlviv bogdanvlviv changed the title Add rails test:channels, and fix Action Cable templates Add rails test:channels and fix Action Cable templates Jan 16, 2019
jeremy
jeremy approved these changes Jan 16, 2019
Add this rake task to test channels only.
We've added `rails test:mailboxes` recently in the same way rails#34828.
@bogdanvlviv bogdanvlviv force-pushed the actioncable-testing-34933 branch from 53b5bca to d7097cf Jan 16, 2019
@kaspth kaspth merged commit 7e52e3b into rails:master Jan 16, 2019
2 checks passed
@bogdanvlviv bogdanvlviv deleted the actioncable-testing-34933 branch Jan 16, 2019
bogdanvlviv added a commit to bogdanvlviv/rails that referenced this issue Jan 21, 2019
Rails generates `test/channels`(rails#34933) and
even allows `rails test:channels` (rails#34947).
`rails stats` has been providing info about `app/channels`,
it makes sence to add `test/channels` as well.
bogdanvlviv added a commit to bogdanvlviv/rails that referenced this issue Jan 21, 2019
Rails generates `test/channels`(rails#34933) and
even allows `rails test:channels` (rails#34947).
`rails stats` has been providing info about `app/channels`,
it makes sense to add `test/channels` as well.

(I've changed test because we generate `test/channels` with some code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants