New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize boilerplate setup code for JavaScript libraries #34949

Merged
merged 1 commit into from Jan 16, 2019

Conversation

Projects
None yet
3 participants
@javan
Copy link
Member

javan commented Jan 16, 2019

As requested by @dhh

- import Rails from "@rails/ujs"
- Rails.start()
+ require("@rails/ujs").start()

- import * as ActiveStorage from "@rails/activestorage"
- ActiveStorage.start()
+ require("@rails/activestorage").start()

- import Turbolinks from "turbolinks"
- Turbolinks.start()
+ require("turbolinks").start()
@kaspth

kaspth approved these changes Jan 16, 2019

@javan javan force-pushed the javan:js/compact-start branch from bdeaf91 to 385d31d Jan 16, 2019

@javan javan merged commit a5fee7d into rails:master Jan 16, 2019

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@javan javan deleted the javan:js/compact-start branch Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment