Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document the possibility of app initializers running before gem initializers #35055

Merged
merged 1 commit into from Jan 26, 2019

Conversation

Projects
None yet
2 participants
@bughit
Copy link
Contributor

bughit commented Jan 25, 2019

and suggest a workaround

Summary

Per #35025, rails provides no guarantee that app initializers will run after gem initializers, which is unfortunate as it makes app initialization non-deterministic and brittle. App init code that depends on a given gem being fully initialized and integrated into rails could suddenly break after inclusion of an unrelated gem (and even it's position in the gem file)

So this possibility should be documented and a workaround suggested.

@rails-bot rails-bot bot added the docs label Jan 25, 2019

@rafaelfranca rafaelfranca merged commit c5fd501 into rails:master Jan 26, 2019

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ruby-bench-server pushed a commit to tgxworld/rails that referenced this pull request Jan 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.