Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error saving Action Text content containing non-blob attachables #35057

Merged
merged 1 commit into from Jan 26, 2019

Conversation

@javan
Copy link
Member

@javan javan commented Jan 25, 2019

Failing test before the ActionText::RichText change:

Error:
ActionText::ModelTest#test_embed_extraction_only_extracts_file_attachments:
ArgumentError: Could not find or build blob: expected attachable, got #<ActionText::Attachables::RemoteImage:0x00007fb0259fef70 @url="http://example.com/cat.jpg", @content_type="image", @width=nil, @height=nil>
@rails-bot rails-bot bot added the actiontext label Jan 25, 2019
Failing test before the ActionText::RichText change:

```
Error:
ActionText::ModelTest#test_embed_extraction_only_extracts_file_attachments:
ArgumentError: Could not find or build blob: expected attachable, got #<ActionText::Attachables::RemoteImage:0x00007fb0259fef70 @url="http://example.com/cat.jpg", @content_type="image", @width=nil, @height=nil>
```
@javan javan force-pushed the javan:actiontext/blob-embeds-only branch from 8f70ef0 to 48c6ef9 Jan 25, 2019
@kaspth
kaspth approved these changes Jan 25, 2019
@javan javan merged commit d90593d into rails:master Jan 26, 2019
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@javan javan deleted the javan:actiontext/blob-embeds-only branch Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants