Support before_reset callback in CurrentAttributes #35063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is good. Can you add the CHANGELOG entry? |
|
On the other hand, would it be better to have resets imply before_reset? If not, then perhaps we should also add a after_reset alias to resets (or the other way around) for readability. |
|
I thought about changing |
|
Thank you @rafaelfranca and @kaspth! Adding an |
rosa
force-pushed
the
current-before-reset-callback
branch
from
ac79e97
to
75b987c
Compare
This is useful when we need to do some work associated to `Current.reset` but that work depends on the values of the current attributes themselves. This cannot be done in the supported `resets` callback because when the block is executed, CurrentAttributes's instance has already been reset. For symmetry, `after_reset` is defined as alias of `resets`.
rosa
force-pushed
the
current-before-reset-callback
branch
from
75b987c
to
2ce8455
Compare
rafaelfranca
added a commit
that referenced
this issue
Feb 4, 2019
Support before_reset callback in CurrentAttributes
suketa
added a commit
to suketa/rails_sandbox
that referenced
this issue
Jul 27, 2019
Support before_reset callback in CurrentAttributes rails/rails#35063
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Summary
This PR adds a
before_resetcallback inCurrentAttributes. The existingresetscallback runs afterresethas been called on the instance, which means we can't use it to do work that depends on the instance values, only to reset global independent collaborators likeTime.zone.I think this might need something added to the
CHANGELOG, I'll add it if you think thisbefore_resetis useful and can be added to Rails.