Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Cable: support channel_prefix for Postgres subscription adapter #35276

Merged
merged 1 commit into from Feb 15, 2019

Conversation

@palkan
Copy link
Contributor

@palkan palkan commented Feb 14, 2019

Summary

The same DB could be used by multiple apps (or engines, see #34714), thus we need a way to avoid naming conflicts.

The functionality has been already implemented for Redis (#27425), we only need to include the module.

@jeremy jeremy merged commit c43c839 into rails:master Feb 15, 2019
1 of 2 checks passed
yahonda added a commit to yahonda/rails that referenced this issue Feb 15, 2019
…st (NameError)

```
$ bundle exec ruby -w -Itest test/subscription_adapter/postgresql_test.rb
Traceback (most recent call last):
	1: from test/subscription_adapter/postgresql_test.rb:8:in `<main>'
test/subscription_adapter/postgresql_test.rb:10:in `<class:PostgresqlAdapterTest>': uninitialized constant PostgresqlAdapterTest::ChannelPrefixTest (NameError)
```

https://travis-ci.org/rails/rails/jobs/493530508

Follow up rails#35276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants