Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Deprecate mismatched collation comparison for uniquness validator #35350
In MySQL, the default collation is case insensitive. Since the
I'd like to deprecate the implicit default enforcing since I frequently
Note that this change has no effect to sqlite3, postgresql, and
As far as I can see, Basecamp, Shopify, and GitHub are using MySQL (or MariaDB).
I'm going to merge this, since the case sensitive comparison on the case insensitive column is potentially problematic, the enforcing implicitly would causes any problems silently without being noticed by MySQL users.
If the deprecation message would be seen on the apps using MySQL, I strongly recommend to confirm the query execution plan and data integrity on the database, and to reconsider that the case sensitive comparison on the case insensitive column is whether or not what you want.