Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version awareness to rails db:system:change #35522

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
2 participants
@gmcgibbon
Copy link
Member

commented Mar 8, 2019

Summary

Fixes #35520. rails db:system:change doesn't support switching out database gems locked to specific versions. This fixes that.

I opted for 2 gsubs to keep the logic simple, and keep support for comment substitutes. If we don't care about the comments, I can merge the two regexes to only sub the gem entry once.

@rails-bot rails-bot bot added the railties label Mar 8, 2019

@gmcgibbon gmcgibbon force-pushed the gmcgibbon:rails_db_system_change_versioning branch from a9eaf7b to dcbb79d Mar 8, 2019

@kaspth kaspth merged commit 199de6b into rails:master Mar 8, 2019

3 checks passed

buildkite/rails Build #59314 passed (19 minutes, 53 seconds)
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gmcgibbon gmcgibbon deleted the gmcgibbon:rails_db_system_change_versioning branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.