Add locale option to #parameterize #35571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameterize is triggering I18n#transliterate. This method already accepts a locale. It would be cleaner if similar to other string inflection methods #parameterize also accepted 'locale' as a parameter.
kaspth
reviewed
Mar 11, 2019
| def parameterize(string, separator: "-", preserve_case: false, locale: nil) | ||
| # Replace accented chars with their ASCII equivalents. | ||
| parameterized_string = transliterate(string) | ||
| parameterized_string = transliterate(string, locale) |
Contributor
There was a problem hiding this comment.
Shouldn't this be locale: locale?
Contributor
Author
|
@sharang-d Are you adding it to your PR with tests or should I change it? |
Contributor
|
@KaanOzkan I'm including it in my changes if that's alright :) |
Contributor
Author
|
@sharang-d Thank you! Please go ahead, I didn't want to change anything without tests again and you already started testing them. Thanks again. |
suketa
added a commit
to suketa/rails_sandbox
that referenced
this pull request
Sep 8, 2019
Add locale option to #parameterize rails/rails#35571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
parameterizeis triggeringI18n#transliterate. This method alreadyaccepts a locale. It would be cleaner if, similar to other string inflection
methods,
parameterizealso accepted 'locale' as a parameter.https://github.com/ruby-i18n/i18n/blob/master/lib/i18n.rb#L268