Drop microseconds in job argument assertions#35713
Merged
gmcgibbon merged 1 commit intoMar 22, 2019
Merged
Conversation
gmcgibbon
force-pushed
the
drop_nsec_in_job_argument_assertions
branch
from
1ab3e27 to
7f03862
Compare
Contributor
|
Should we mention this in the guides too? |
This was referenced Mar 28, 2020
Closed
This was referenced Jun 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When serializing arguments for Active Jobs,
Time,DateTime, andActiveSupport::TimeInZoneall lose a certain degree of precision eg.now = Time.now; Time.iso8601(now.iso8601) == now. We can fix this by adding precision (now = Time.now; Time.iso8601(now.iso8601(20)) == now), but that adds unnecessary size to job payloads. Instead, I've opted to modify the test helper to drop microseconds (and nanoseconds) from passed in time job arguments.