Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix bug in Range comparisons when comparing to excluded-end Range #35776
Conversation
rails-bot
bot
added
the
activesupport
label
Mar 28, 2019
rafaelfranca
merged commit a7723b8
into
rails:master
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
owst commentedMar 28, 2019
Summary
I noticed that the addition of support for Range arguments to
#cover?and friends in #32938 didn't correctly handle exclude-end arguments:Before:
After:
Other Information
See https://git.io/fjTtz for the commit against Ruby core that added
support for Range arguments, with similar handling of this case.