Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename `i18n_full_message` config option to `i18n_customize_full_message` #35789

Merged

Conversation

Projects
None yet
2 participants
@prathamesh-sonpatki
Copy link
Member

commented Mar 29, 2019

  • I feel i18n_customize_full_messages explains the meaning of the
    config better.
  • Followup of #32956
Rename `i18n_full_message` config option to `i18n_customize_full_mess…
…age`

- I feel `i18n_customize_full_messages` explains the meaning of the
  config better.
- Followup of #32956

@rafaelfranca rafaelfranca merged commit 8638c7a into rails:master Mar 29, 2019

3 checks passed

buildkite/rails Build #59950 passed (17 minutes, 43 seconds)
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

abhaynikam added a commit to abhaynikam/rails that referenced this pull request Mar 29, 2019

rafaelfranca added a commit that referenced this pull request Mar 29, 2019

Merge pull request #35792 from abhaynikam/35789-follow-up-to-update-t…
…est-description-for-i18n-customize-full-message

Updated the test description for i18n-customize-full-message after rename in #35789

@prathamesh-sonpatki prathamesh-sonpatki deleted the prathamesh-sonpatki:customize-full-message branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.