Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `after_save_commit` callback shortcut #35804

Merged
merged 2 commits into from Apr 2, 2019

Conversation

Projects
None yet
3 participants
@dhh
Copy link
Member

commented Mar 30, 2019

We have shortcuts for declaring after_commit callbacks for update and create, but not the very common combination of using them both together. This adds that.

@rails-bot rails-bot bot added the activerecord label Mar 30, 2019

@dhh dhh merged commit 59bed68 into master Apr 2, 2019

0 of 2 checks passed

buildkite/rails Build #60063 scheduled
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@dhh dhh deleted the add-after_save_commit branch Apr 2, 2019

@sharang-d

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

Do you think we should add the method to https://github.com/rails/rails/blob/7020c6f9721c36616e58cba344549183aa091233/guides/source/active_record_callbacks.md#transaction-callbacks where we talk about the three after_<something>_commit callbacks?

@dhh

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

@sharang-d

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

I'll work on a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.