Add after_save_commit callback shortcut
#35804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on: [ :create, :update ]`.
rafaelfranca
approved these changes
Apr 2, 2019
|
Do you think we should add the method to https://github.com/rails/rails/blob/7020c6f9721c36616e58cba344549183aa091233/guides/source/active_record_callbacks.md#transaction-callbacks where we talk about the three |
|
👍
…On Wed, Apr 3, 2019 at 12:50 AM Sharang Dashputre ***@***.***> wrote:
Do you think we should add the method to
https://github.com/rails/rails/blob/7020c6f9721c36616e58cba344549183aa091233/guides/source/active_record_callbacks.md#transaction-callbacks
where we talk about the three after_<something>_commit callbacks?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#35804 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAKtflMse7veEvSxcFiiPw4-mNe0TmCks5vdF06gaJpZM4cT2Rj>
.
|
|
I'll work on a PR for it. |
abhaynikam
added a commit
to abhaynikam/rails
that referenced
this pull request
Apr 5, 2019
…n guide after rails#35804 [ci skip]
suketa
added a commit
to suketa/rails_sandbox
that referenced
this pull request
Oct 5, 2019
Add `after_save_commit` callback shortcut rails/rails#35804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have shortcuts for declaring after_commit callbacks for update and create, but not the very common combination of using them both together. This adds that.