Add ActionDispatch::SystemTestCase#fill_in_rich_text_area #35885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull bot
pushed a commit
to hakusaro/rails
that referenced
this pull request
May 5, 2019
The virtual attributes(`attachment` and `rich_text`) can't set value with `fill_in`. So avoid using it. Once rails#35885 is merged, will be modified to use it. Also, add checking attachment attached or not for avoiding `DelegationError` when attachment didn't attach.
y-yagi
added a commit
that referenced
this pull request
May 5, 2019
The virtual attributes(`attachment` and `rich_text`) can't set value with `fill_in`. So avoid using it. Once #35885 is merged, will be modified to use it. Also, add checking attachment attached or not for avoiding `DelegationError` when attachment didn't attach.
Contributor
|
Nice to see someone using Capybaras custom selector types. Just to point out that most of Capybaras built-in selectors only apply the locator conditions if it's not nil, which allows for using without the locator if there is only one matching field within the current scope. Might be a useful addition here |
twalpole
reviewed
May 18, 2019
| # # <trix-editor input="trix_input_1"></trix-editor> | ||
| # fill_in_rich_text_area "message[content]", with: "Hello <em>world!</em>" | ||
| def fill_in_rich_text_area(locator, with:) | ||
| page.execute_script(<<~JS, find(:rich_text_area, locator).native, with.to_s) |
Contributor
There was a problem hiding this comment.
There should be no need to call .native here, Capybara will convert to the correct parameter for the driver, and with Capybara 3.2+ you can call execute_script on the element itself which will pass the element as the first argument
page.find(:rich_text_area, locator).execute_script(<<~JS, with.to_s)
...
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fill_in_rich_text_arealocates a Trix editor and fills it in with the given HTML: